#!/usr/bin/env perl # Copyright (C) 2012 by CPqD # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation, either version 3 of the License, or # (at your option) any later version. # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # You should have received a copy of the GNU General Public License # along with this program. If not, see . package Git::Hooks::CheckLog; { $Git::Hooks::CheckLog::VERSION = '0.031'; } # ABSTRACT: Git::Hooks plugin to enforce commit log policies. use 5.010; use utf8; use strict; use warnings; use Git::Hooks qw/:DEFAULT :utils/; use File::Slurp; use List::MoreUtils qw/uniq/; my $PKG = __PACKAGE__; (my $CFG = __PACKAGE__) =~ s/.*::/githooks./; ############# # Grok hook configuration, check it and set defaults. sub _setup_config { my ($git) = @_; my $config = $git->get_config(); $config->{lc $CFG} //= {}; my $default = $config->{lc $CFG}; $default->{'title-required'} //= [1]; $default->{'title-max-width'} //= [50]; $default->{'title-period'} //= ['deny']; $default->{'body-max-width'} //= [72]; return; } ########## sub read_msg_encoded { my ($git, $msgfile) = @_; my $encoding = $git->config(i18n => 'commitencoding') || 'utf-8'; my $msg = read_file($msgfile, { binmode => ":encoding($encoding)", err_mode => 'carp' }) or die "$PKG: Cannot read message file '$msgfile' with encoding '$encoding'\n"; # Strip the patch data from the message. $msg =~ s:^diff --git a/.*::ms; # strip comment lines $msg =~ s/^#.*\n?//mg; return $msg; } sub _spell_checker { my ($git, $msg) = @_; my %extra_options; if (my $lang = $git->config($CFG => 'spelling-lang')) { $extra_options{lang} = $lang; } unless (state $tried_to_check) { unless (eval { require Text::SpellChecker; }) { my $message = $@ ? $@ : ''; die "$PKG: Could not require Text::SpellChecker module to spell messages.\n$message\n"; } # Text::SpellChecker uses either Text::Hunspell or # Text::Aspell to perform the checks. But it doesn't try to # load those modules until we invoke its next_word method. So, # in order to detect errors in those modules we first create a # bogus Text::SpellChecker object and force it to spell a word # to see if it can go so far. my $checker = Text::SpellChecker->new(text => 'a', %extra_options); my $word = eval { $checker->next_word(); }; die "$PKG: Cannot spell check using Text::SpellChecker.\n$@\n" if $@; $tried_to_check = 1; }; return Text::SpellChecker->new(text => $msg, %extra_options); } sub check_spelling { my ($git, $id, $msg) = @_; return unless $git->config($CFG => 'spelling'); # Check all words comprised of at least three Unicode letters my $checker = _spell_checker($git, join("\n", uniq($msg =~ /\b(\p{Cased_Letter}{3,})\b/gi))); my $errors = 0; foreach my $badword ($checker->next_word()) { unless ($errors++) { warn "$PKG: $id\'s log has the following spelling problems in it.\n"; } my @suggestions = $checker->suggestions($badword); if (defined $suggestions[0]) { warn " $badword (suggestions: ", join(', ', @suggestions), ")\n"; } else { warn " $badword (no suggestions)\n"; } } die "\n" if $errors; return; } sub check_patterns { my ($git, $id, $msg) = @_; foreach my $match ($git->config($CFG => 'match')) { if ($match =~ s/^!\s*//) { $msg !~ /$match/m or die "$PKG: $id\'s log SHOULD NOT match \Q$match\E.\n"; } else { $msg =~ /$match/m or die "$PKG: $id\'s log SHOULD match \Q$match\E.\n"; } } return; } sub check_title { my ($git, $id, $title, $neck, $body) = @_; return unless $git->config($CFG => 'title-required'); { my $title_lines = ($title =~ tr/\n/\n/); $title_lines += 1 if defined $neck; die "$PKG: $id\'s log title has $title_lines lines but should have only 1!\n" unless $title_lines == 1; } # Here I was going to check the $neck length to make sure there is # only one blank line between the title and the body. However, I # soon realised that Git takes care of this and gets rid of any # extra blank line in the original message before passing it to # the commit-msg hook. if (my $max_width = $git->config($CFG => 'title-max-width')) { die "$PKG: $id\'s log title should be at most $max_width characters wide, but it has ", length($title), "!\n" if length($title) > $max_width; } if (my $period = $git->config($CFG => 'title-period')) { if ($period eq 'deny') { $title !~ /\.$/ or die "$PKG: $id\'s log title SHOULD NOT end in a period.\n"; } elsif ($period eq 'require') { $title =~ /\.$/ or die "$PKG: $id\'s log title SHOULD end in a period.\n"; } elsif ($period ne 'allow') { die "$PKG: Invalid value for the $CFG.title-period option: '$period'.\n"; } } return; } sub check_body { my ($git, $id, $body) = @_; if (my $max_width = $git->config($CFG => 'body-max-width')) { while ($body =~ /^(.*)/gm) { my $line = $1; die "$PKG: $id\'s log body lines should be at most $max_width characters wide, but there is one with ", length($line), "!\n" if length($line) > $max_width; } } return; } sub check_message { my ($git, $commit, $msg) = @_; my $id = defined $commit ? substr($commit->{commit}, 0, 7) : 'commit'; check_spelling($git, $id, $msg); check_patterns($git, $id, $msg); my ($title, $neck, $body) = split /(\n\n+)/s, $msg, 2; check_title($git, $id, $title, $neck, $body); check_body($git, $id, $body); return; } sub check_message_file { my ($git, $commit_msg_file) = @_; _setup_config($git); check_message($git, undef, read_msg_encoded($git, $commit_msg_file)); return; } sub check_ref { my ($git, $ref) = @_; foreach my $commit ($git->get_affected_ref_commits($ref)) { check_message($git, $commit, $commit->{body}); } return; } # This routine can act both as an update or a pre-receive hook. sub check_affected_refs { my ($git) = @_; _setup_config($git); return if im_admin($git); foreach my $ref ($git->get_affected_refs()) { check_ref($git, $ref); } return; } # Install hooks COMMIT_MSG \&check_message_file; UPDATE \&check_affected_refs; PRE_RECEIVE \&check_affected_refs; 1; __END__ =pod =head1 NAME Git::Hooks::CheckLog - Git::Hooks plugin to enforce commit log policies. =head1 VERSION version 0.031 =head1 DESCRIPTION This Git::Hooks plugin can act as any of the below hooks to enforce policies on the commit log messages. =over =item C This hook is invoked during the commit, to check if the commit log message complies. =item C This hook is invoked multiple times in the remote repository during C, once per branch being updated, to check if the commit log messages of all commits being pushed comply. =item C This hook is invoked once in the remote repository during C, to check if the commit log messages of all commits being pushed comply. =back Projects using Git, probably more than projects using any other version control system, have a tradition of establishing policies on the format of commit log messages. The REFERENCES section below lists some of the more important ones. This plugin allows one to enforce most of the more established policies. The default configuration already enforces the most common one. To enable the plugin you should define the appropriate Git configuration option like one of these: git config --add githooks.commit-msg CheckLog git config --add githooks.pre-receive CheckLog git config --add githooks.update CheckLog =for Pod::Coverage read_msg_encoded check_spelling check_patterns check_title check_body check_message check_ref =head1 NAME Git::Hooks::CheckLog - Git::Hooks plugin to enforce commit log policies. =head1 CONFIGURATION The plugin is configured by the following git options. =head2 githooks.checklog..title-required [01] The first line of a Git commit log message is usually called the 'title'. It must be separated by the rest of the message (it's 'body') by one empty line. This option, which is 1 by default, makes the plugin check if there is a proper title in the log message. =head2 githooks.checklog..title-max-width N This option specifies a limit to the width of the title's in characters. It's 50 by default. If you set it to 0 the plugin imposes no limit on the title's width. =head2 githooks.checklog..title-period [deny|allow|require] This option defines the policy regarding the title's ending in a period (a.k.a. full stop ('.')). It can take three values: =over =item deny This means that the title SHOULD NOT end in a period. This is the default value of the option, as this is the most common policy. =item allow This means that the title MAY end in a period, i.e., it doesn't matter. =item require This means that the title SHOULD end in a period. =back =head2 githooks.checklog..body-max-width N This option specifies a limit to the width of the commit log message's body lines, in characters. It's 72 by default. If you set it to 0 the plugin imposes no limit on the body line's width. =head2 githooks.checklog..match [!]REGEXP This option may be specified more than once. It defines a list of regular expressions that will be matched against the commit log messages. If the '!' prefix isn't used, the log has to match the REGEXP. Otherwise, the log must not match the REGEXP. =head2 githooks.checklog..spelling [01] This option makes the plugin spell check the commit log message using C. Any spell error will cause the commit or push to abort. Note that C isn't required to install C. So, you may see errors when you enable this check. Please, refer to the module's own documentation to see how to install it and its own dependencies (which are C or C). =head2 githooks.checklog..spelling-lang ISO The Text::SpellChecker module uses defaults to infer which language is must use to spell check the message. You can make it use a particular language passing its ISO code to this option. =head2 i18n.commitEncoding ENCODING This is not a CheckLog option. In fact, this is a native option of Git, which semantics is defined in C. It tells Git which character encoding the commit messages are stored in and defaults to C. When this plugin is used in the C hook, the message file is read and its contents are checked against the encoding specified by this option. =head1 EXPORTS This module exports the following routines that can be used directly without using all of Git::Hooks infrastructure. =head2 check_message_file GIT, MSGFILE This is the routine used to implement the C hook. It needs a C object and the name of a file containing the commit message. =head2 check_affected_refs GIT This is the routing used to implement the C and the C hooks. It needs a C object. =head1 REFERENCES =over =item git-commit(1) Manual Page (L) This Git manual page has a section called DISCUSSION which discusses some common log message policies. =item Linus Torvalds GitHub rant (L) In this note, Linus says why he dislikes GitHub's pull request interface, mainly because it doesn't allow him to enforce log message formatting policies. =item MediaWiki Git/Commit message guidelines (L) This document defines the MediaWiki's project commit log message guidelines. =item Proper Git Commit Messages and an Elegant Git History (L) This is a good discussion about commit log message formatting and the reasons behind them. =back =head1 AUTHOR Gustavo L. de M. Chaves =head1 COPYRIGHT AND LICENSE This software is copyright (c) 2013 by CPqD . This is free software; you can redistribute it and/or modify it under the same terms as the Perl 5 programming language system itself. =cut